Implement change proposed in "All MRs that add unit tests conflict with each other" #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebasing after I merged #599 will also require adding one extra |
Fixes containers#420 Signed-off-by: Jonathan Wright <[email protected]>
Signed-off-by: Jonathan Wright <[email protected]>
The other three references to bash already use "bash" instead of "/bin/bash". Similarly, "#!/bin/bash" has already been replaced with "#!/usr/bin/env bash". Signed-off-by: Jonathan Wright <[email protected]>
|
Rebases done. Let me know if more are needed. |
smcv
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #420 using the proposed approach of defining ok(), done_testing(), and shifting the TAP plan from being written at the start to being written at the end. I also introduced an ok_skip() function, but I'm happy to change all uses to ok "# SKIP ..." if you prefer that.
This pull request also has two trivial fixes to the tests:
Let me know if you'd rather these two changes were in separate pull requests.