Fixes for autoconf/automake. #575
Conversation
There was a problem hiding this comment.
A Meson build system was added in 0.6.0 and is working pretty well by now, so I'm very tempted to remove the Autotools build system in preference to merging changes into it; so spending time on improving the Autotools build system might not be very productive.
First, pkg-config is in a non-standard location, so I had to copy pkg.m4 into m4.
Please set the environment variable ACLOCAL_PATH to point to where your pkg.m4 is, instead of copying pkg.m4 into every project you compile, which scales poorly - if you only compile 5 projects, then that's 5 maintainers who have to spend time looking at that change, and then review requests to update the bundled copy for the rest of time.
Makefile.am
Outdated
| @@ -51,7 +51,7 @@ test_extra_programs = \ | |||
| tests/try-syscall \ | |||
| $(NULL) | |||
|
|
|||
| test-bwrap: bwrap | |||
| test-bwrap$(EXEEXT): bwrap | |||
There was a problem hiding this comment.
This part looks fine, but please make it its own commit. If you find yourself writing out a list in a commit message, that's often a sign that it should have been more than one commit.
| @@ -6,7 +6,7 @@ AC_CONFIG_AUX_DIR([build-aux]) | |||
|
|
|||
| AC_USE_SYSTEM_EXTENSIONS | |||
|
|
|||
| AM_INIT_AUTOMAKE([1.11 -Wno-portability foreign no-define tar-ustar no-dist-gzip dist-xz]) | |||
| AM_INIT_AUTOMAKE([1.11 -Wno-portability foreign no-define tar-ustar no-dist-gzip dist-xz subdir-objects]) | |||
There was a problem hiding this comment.
Again, this part looks fine, but should be its own commit.
Indeed, particularly because this is a maintainer-only task and pkg.m4 is not needed when using the release tarballs e.g. bubblewrap-0.8.0.tar.xz, which include a copy of pkg.m4 (inlined into aclocal.m4) as well as the final generated configure script with pkg-config support. |
|
I have removed the pkg.m4 copied-in here. Now only 2 lines are changed. |
|
Did you see the reviews where I said "this part is fine, but should be its own commit"? Those parts were fine, but should have been their own commits. |
|
I've split up the commit myself. I hope that illustrates what I meant by "If you find yourself writing out a list in a commit message, that's often a sign that it should have been more than one commit". |
|
Unfortunately, distcheck is now failing in CI: I'm very tempted to resolve this by deleting the Autotools build system, leaving only Meson, rather than by reviewing or testing further Autotools changes. |
|
The part that I've split into commit "Silence Automake warning for items in TESTS being renamed" seems fine. I've opened #622 to land that. The part that adds |
automake 1.16.3 emits warnings about future deprecation of its old behavior - putting object files at the top-level. This project does not rely on the old behavior, so we can silence the warning by opting in to the new behavior. Signed-off-by: David M. Rogers <[email protected]> [smcv: Split out from a larger commit, re-worded commit message] Signed-off-by: Simon McVittie <[email protected]>
|
The autotools build log indicates a permissions error It is related to the chmod/mkdir sequence earlier: I'll look for a fix that creates a .deps directory at that step. |
frobnitzem
force-pushed
the
autoconf
branch
2 times, most recently
from
fc6b4e9
to
6305fcb
Compare
Signed-off-by: David M. Rogers <[email protected]>
|
It is intentional that distcheck runs with the source directory non-writeable: it's trying to make sure that an out-of-tree (srcdir != builddir) build doesn't alter the source code, only the build directory. This is a general Autotools thing, not specific to bubblewrap. |
People have now had two years and multiple releases to migrate to meson. It might be worth asking what the reason for continuing to use autotools here is, before proceeding further. I would have assumed that if there were lingering issues with the meson conversion they would have been discovered by now, so "teething troubles" should not be the answer... |
|
Probably best to close this and land #625 instead. |
|
Yeah, I'm still wondering what the original reason was for trying to improve the autotools build which is already deprecated regardless. It would be good to know if people are actually running into issues with the port to meson, but since no one has actually reported such an issue, it feels like we should assume there are no issues and declare success, then delete autotools. |
Done after 0.10.0, so this PR is no longer applicable. |
Solves three issues I ran into when executing autogen.sh on my system.
First, pkg-config is in a non-standard location, so I had to copy pkg.m4 into m4. Note this file is copyrighted under the GPL-2, which matches the bubblewrap copyright.
Second, automake 1.16.3 emits warnings about future deprecation of its old behavior - putting object files at the top-level. Silencing these warnings requires changing the AM_INIT_AUTOMAKE call from configure.ac.
Third, the manual rule for test-wrap in Makefile-bwrap.in threw a warning because automake renames the target of things in TESTS.
Note: the full error traceback from autoreconf -i is here: