Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash completion fixes #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bash completion fixes #238

wants to merge 1 commit into from

Conversation

vn971
Copy link
Contributor

@vn971 vn971 commented Oct 12, 2017

sort entries, add some and fix some

@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

sort entries, add some and fix some
@rh-atomic-bot
Copy link

Can one of the admins verify this patch?
I understand the following commands:

  • bot, add author to whitelist
  • bot, test pull request
  • bot, test pull request once

@smcv smcv changed the title Add completion bash completion fixes Jun 10, 2021
Copy link
Collaborator

@smcv smcv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be merged, because it's an improvement, even though it isn't complete.

Since this MR was opened, we have also gained:

Options without arguments: --share-net

Options with arguments: --bind-try --ro-bind-try --dev-bind-try --proc --json-status-fd --userns --userns2 --pidns

and the -- pseudo-argument to terminate argument parsing.

@vn971
Copy link
Contributor Author

vn971 commented Jun 10, 2021

@smcv what do I need to do to follow-up on this? (I still use bubblewrap so I could finish the already started task)

@smcv
Copy link
Collaborator

smcv commented Jun 10, 2021

If you add the new options to this PR and force-push, that would certainly be an improvement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants