Add hyperv management tools to Windows image #316
Conversation
n1hility
force-pushed
the
add-mgmt
branch
5 times, most recently
from
21b9f59 to
cb4c899
Compare
|
PTAL @cevich (Also note the timebomb extension in here) |
Extend timebomb om cache_images Signed-off-by: Jason T. Greene <[email protected]>
|
Cirrus CI build successful. Found built image names and IDs:
|
|
LGTM. Please merge whenever you're ready. |
|
I'm going to update this PR to add a storage size increase based on recent failures @baude observed |
Signed-off-by: Jason T. Greene <[email protected]>
|
Cirrus CI build successful. Found built image names and IDs:
|
|
PTAL one more time @cevich or @edsantiago I added a small storage change so just need to make sure you guys are cool with it |
|
Versions:
|
| @@ -222,5 +222,5 @@ cd - | |||
| lilto $SUDO dnf update -y | |||
|
|
|||
| # FIXME FIXME FIXME 2023-11-16 TEMPORARY to get crun-1.11.2 | |||
| timebomb 20231120 "force-update crun >= 1.11.1 on f38" | |||
| timebomb 20231220 "force-update crun >= 1.11.1 on f38" | |||
There was a problem hiding this comment.
Well, I discovered a nasty usability problem with timebomb: crun looks good, but without looking at logs it's impossible to tell whether or not it's because of this block.
|
Eh, we can do the podman testing on our end. /lgtm Thanks @n1hility |
|
@edsantiago I am testing it in containers/podman#20914 but still struggling with how to get gvproxy from where it is to where it needs to be ... |
| - device_name: '/dev/sda1' | ||
| volume_size: 200 | ||
| volume_type: 'gp2' | ||
| delete_on_termination: true |
There was a problem hiding this comment.
This LGTM, though from what I've seen in Mac-land, default gp2 and gp3 may be "too slow" for podman-machine testing. IIRC, they only provision 150 IOPS. Going up to 'gp3' + 600 IOPS is still not great, but it's a big improvement for a small increase in cost.
If you have a chance to re-push/build, would you mind switching to gp3 and setting iops: 600?
There was a problem hiding this comment.
sure good point will fix silly to have a beefy box with slow storage
There was a problem hiding this comment.
Yeah. I'm fine if that happens here or in a followup PR.
|
Merging since this passes podman CI. Let's do the storage-speed bump in a followup. |
Update the feature to pull in management tools to support the ability to use powershell scripts and the hyper-v management tools for debugging