Fix podman_tooling script #136
Conversation
cevich
force-pushed
the
fix_podman_tooling
branch
from
3af9ff3 to
d5f024b
Compare
|
|
cevich
force-pushed
the
fix_podman_tooling
branch
from
d5f024b to
ccc75d9
Compare
There was a problem hiding this comment.
All the sudo bash makes me cringe. Why not just add a hashbang-bash line to the script, make it 755, and invoke it directly? (This is a pet peeve of mine: let the script itself determine the interpreter it wants).
Also, CI is failing with a "kubik" error; sounds like the Ubuntu issue from a week or two ago.
Co-authored-by: Chris Evich <[email protected]> Signed-off-by: Lokesh Mandvekar <[email protected]>
I was afraid of making it appear like users should ever try and execute that script. I s'pose I could make it executable in the setup script.
This is expected since this PR depends on #134 |
cevich
force-pushed
the
fix_podman_tooling
branch
2 times, most recently
from
01bb5c3 to
c1258d4
Compare
|
In fact, let's try it with #134 now and see if it builds successfully. |
This script is needed by both podman and buildah CI. However a bug in
the line `export GOPATH="${GOPATH:/var/tmp/go}"` was causing it to
silently exit before doing it's job. Fortunately the downstream build
systems are somewhat tolerant, so the problem wasn't noticed at image
build time.
Simplify the script by requiring it to be called under $SUDO, this
allows moving a bunch of golang variable definitions into the script and
also making it `set -e` so failures are noticed sooner.
Signed-off-by: Chris Evich <[email protected]>
cevich
force-pushed
the
fix_podman_tooling
branch
from
c1258d4 to
6b66a74
Compare
|
Force-push: Woopsie, forgot to do the |
|
Cirrus CI build successful. Image ID |
|
Thanks @edsantiago |
|
Status note: Waiting for #134 to merge, then this can go in. |
Depends on: #134
This script is needed by both podman and buildah CI. However a bug in
the line
export GOPATH="${GOPATH:/var/tmp/go}"was causing it tosilently exit before doing it's job. Fortunately the downstream build
systems are somewhat tolerant, so the problem wasn't noticed at image
build time.
Simplify the script by requiring it to be called under $SUDO, this
allows moving a bunch of golang variable definitions into the script and
also making it
set -eso failures are noticed sooner.Ref: Silent failure example: https://cirrus-ci.com/task/6089758945312768?logs=main#L1905-L1906