coredns: work on tcp requests concurrently #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a 3s timeout to all tcp connections, we do not want clients to keep the connections open forever. Also do not allow more than one message per connection. The API is a bit weird, we first get the message then have to poll again where it return None otherwise the reply will not be send. Signed-off-by: Paul Holzinger <[email protected]>
Right now for a single network all requests where processed serial and with tcp a caller is able to block us for a long time if it just opens the connection but sends very little or no data. To avoid this always spawn a new task if we accept a new tcp connection. We could do the same for udp however my testing with contrib/perf/run.sh has shown that it slows things down as the overhead of spawning a task is greater than the few quick simple map lookups so we only spawn where needed. We still have to spawn when forwarding external requests as this can take a long time. Fixes containers#500 Signed-off-by: Paul Holzinger <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mheon PTAL |
|
yeah! LGTM |
|
Tests failed. @containers/packit-build please check. |
|
/lgtm |
openshift-merge-bot
bot
merged commit 07ece81
into
containers:main
39 of 47 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now for a single network all requests where processed serial and
with tcp a caller is able to block us for a long time if it just opens
the connection but sends very little or no data. To avoid this always
spawn a new task if we accept a new tcp connection.
We could do the same for udp however my testing with contrib/perf/run.sh
has shown that it slows things down as the overhead of spawning a task
is greater than the few quick simple map lookups so we only spawn where
needed. We still have to spawn when forwarding external requests as this
can take a long time.
Fixes #500