Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tighten up plugin-finding logic #808

Merged
merged 1 commit into from
Jan 20, 2021
Merged

tighten up plugin-finding logic #808

merged 1 commit into from
Jan 20, 2021

Conversation

squeed
Copy link
Member

@squeed squeed commented Jan 19, 2021

No description provided.

@squeed
Copy link
Member Author

squeed commented Jan 19, 2021

@dcbw

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 70.819% when pulling 405362f on squeed:plugin-name into 77cd8fe on containernetworking:master.

s1061123
s1061123 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dcbw
Copy link
Member

dcbw commented Jan 20, 2021

/lgtm

@dcbw
Copy link
Member

dcbw commented Jan 20, 2021

Once it passes appveyor (eg Windows) and your local test.sh, I'm good with it.

@squeed
tighten up plugin-finding logic
ada6726 
Signed-off-by: Casey Callendrello <[email protected]>
@dcbw dcbw merged commit a5c35b1 into containernetworking:master Jan 20, 2021
@lsm5
Copy link

lsm5 commented Feb 3, 2021

does https://github.com/containernetworking/plugins/blob/master/go.mod#L10 need an update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1061123 s1061123 s1061123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@squeed @coveralls @dcbw @lsm5 @s1061123