Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnitool: support capablity args #440

Merged
merged 1 commit into from
Apr 29, 2017
Merged

Conversation

feiskyer
Copy link
Contributor

This PR adds capability args to cnitool, which will help to pass capability args for portmapping plugin (containernetworking/plugins#1).

$ export CAP_ARGS='{
	"portMappings": [
		{
			"hostPort":      9090,
			"containerPort": 80,
			"protocol":      "tcp",
			"hostIP":        "127.0.0.1"
		}
	]
}'
$ cnitool add mynet /var/run/netns/myns

cc/ @squeed @dcbw

@dcbw
Copy link
Member

dcbw commented Apr 25, 2017

LGTM

@feiskyer
Copy link
Contributor Author

cc @bboreham

@squeed
Copy link
Member

squeed commented Apr 26, 2017

seems reasonable, +1

@dcbw dcbw merged commit a6c96ac into containernetworking:master Apr 29, 2017
@feiskyer feiskyer deleted the cap branch April 29, 2017 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants