Fix unmarshall of results for interface index 0 #434
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the "ips" struct, if the plugin passes interface index as 0 to cni unmarshalling api, index index gets omitted in the result. fixes containernetworking#404 Signed-off-by: vikaschoudhary16 <[email protected]>
|
I think this might be a problem for IPAM plugins which use the same structure, but don't pass anything about interface indexes. Their JSON would now include 0 where before it was empty, and their results do not always correspond to any specific interface index. |
|
@dcbw I thought you were gonna replace that with an |
|
CLosing in favor of containernetworking/plugins#28 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the "ips" struct, if the plugin passes interface index as 0 to
cni unmarshalling api, index index gets omitted in the result.
fixes #404
Signed-off-by: vikaschoudhary16 [email protected]