scripts: cleanup() should rm net container in docker-run.sh #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@squeed You just reviewed my last PR 2 hours ago, maybe you'd like to take a look at this one either. 😄 |
|
LGTM |
|
Ah yes, makes sense. LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, if users do
Running a Docker container with network namespace set up by CNI pluginsby following steps in README, then after this, they'll get a dead net container (busybox) left on their environments.I'm thinking that it would be better if we clean that dead container up and leave the users' environments as clean as before. See
git diff.