Return cni.type.Error instead of plain error #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squeed
reviewed
Mar 17, 2017
pkg/invoke/raw_exec.go
Outdated
| @@ -52,11 +52,7 @@ func pluginErr(err error, output []byte) error { | |||
| if perr := json.Unmarshal(output, &emsg); perr != nil { | |||
| return fmt.Errorf("netplugin failed but error parsing its diagnostic message %q: %v", string(output), perr) | |||
There was a problem hiding this comment.
Do we want to generate a types.Error for this condition as well? Then we can tighten up the return types.
|
LGTM after the change Casey requested. |
This way, we can use Error.Code attribute to check error type without needing to regexp the message string
|
Commit updated with suggestion |
|
LGTM, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we can use Error.Code attribute to check error type without
needing to regexp the message string
kubernetes/kubernetes#43014