Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: logging by adding new logger struct #86

Merged
merged 4 commits into from
Dec 12, 2021
Merged

Fix: logging by adding new logger struct #86

merged 4 commits into from
Dec 12, 2021

Conversation

guacamole
Copy link
Member

  • Added new logger struct to contain zerologger and echo logger
  • In the earlier implementation, the logger was being called in middleware which caused the log messages to return caller as middelware instead of the handler within which made debugging difficult
  • This PR fixes the issue by removing the middleware and calling logger inside each handler

Signed-off-by: guacamole [email protected]

@guacamole
Fix: logging by adding new logger struct
e1b3ba6 
- Added new logger struct to contain zerologger and echo logger
- In the earlier implementaion, the logger was being called in middleware which caused the log messages to return caller as middelware instead of the handler within
- This PR fixes the issue by removing the middleware and calling logger inside each handler

Signed-off-by: guacamole <[email protected]>
@guacamole guacamole self-assigned this Dec 11, 2021
@guacamole
Fix: logging by adding new logger struct
2958a49 
- Added new logger struct to contain zerologger and echo logger
- In the earlier implementaion, the logger was being called in middleware which caused the log messages to return caller as middelware instead of the handler within
- This PR fixes the issue by removing the middleware and calling logger inside each handler

Signed-off-by: guacamole <[email protected]>
@jay-dee7 jay-dee7 marked this pull request as ready for review December 12, 2021 07:10
jay-dee7
jay-dee7 approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@jay-dee7 jay-dee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @guacamole 🥇

@jay-dee7 jay-dee7 merged commit 2a89488 into master Dec 12, 2021
@jay-dee7 jay-dee7 deleted the fix-logging branch December 12, 2021 11:00
@guacamole guacamole mentioned this pull request Dec 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jay-dee7 jay-dee7 jay-dee7 approved these changes

Assignees

@guacamole guacamole

Labels
None yet
Projects
Containerish Road Map 2023-24
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guacamole @jay-dee7