Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Carry #1847] Fix zstd:chunked converter error on duplicated blobs #1885

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

ktock
Copy link
Member

@ktock ktock commented Dec 3, 2024

Carry #1847

This PR fixes the following warning by zstd:chunked converter. This PR fixes that issue by not cleaning up of temporary resources by our own but we rely on containerd's GC instead.

WARN[0038] failed to remove tmp uncompressed layer       error="content digest sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef: not found" uncompressedDesc="&{application/vnd.oci.image.layer.v1.tar sha256:5f70bf18a086007016e948b04aed3b82103a36bea41755b6cddfaf10ace3c6ef 1024 [] map[] [] <nil> }"

reporoducer:

# ctr-remote i pull docker.io/library/tomcat:10.1-jdk21-temurin-noble
# ctr-remote image optimize --oci --period=30 --zstdchunked docker.io/library/tomcat:10.1-jdk21-temurin-noble test

@ktock ktock changed the title Fix zstd error carry [Carry #1847] Fix zstd:chunked converter error on duplicated blobs Dec 3, 2024
@ktock ktock marked this pull request as draft December 4, 2024 01:43
ktock and others added 2 commits December 4, 2024 10:44
@ktock ktock force-pushed the fix-zstd-error-carry branch from 634c241 to 61a30ba Compare December 4, 2024 01:46
@ktock ktock marked this pull request as ready for review December 4, 2024 01:46
@ktock
Copy link
Member Author

ktock commented Dec 4, 2024

cc @apostasie

@ktock ktock requested a review from AkihiroSuda December 4, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants