Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshots: add metadata.db for serve cleanup #1884

Merged
merged 1 commit into from
Dec 3, 2024
Merged

snapshots: add metadata.db for serve cleanup #1884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions snapshot/snapshot.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,15 @@ func (o *snapshotter) cleanup(ctx context.Context, cleanupCommitted bool) error
return nil
}

func (o *snapshotter) cleanupMetadataDB() error {
metadataDBPath := filepath.Join(o.root, "metadata.db")
err := os.Remove(metadataDBPath)
if err != nil {
return err
}
return nil
}

func (o *snapshotter) cleanupDirectories(ctx context.Context, cleanupCommitted bool) ([]string, error) {
// Get a write transaction to ensure no other write transaction can be entered
// while the cleanup is scanning.
Expand Down Expand Up @@ -658,6 +667,11 @@ func (o *snapshotter) Close() error {
if err := o.cleanup(ctx, cleanupCommitted); err != nil {
log.G(ctx).WithError(err).Warn("failed to cleanup")
}

if err := o.cleanupMetadataDB(); err != nil {
log.G(ctx).WithError(err).Warn("failed to cleanup metadata.db")
}

return o.ms.Close()
}

Expand Down
Loading