Fix wasmtime precompilation #700
Conversation
| let compiled_layer = match WasmBinaryType::from_bytes(&layer.layer) { | ||
| Some(Module) => self.engine.precompile_module(&layer.layer)?, | ||
| Some(Component) => self.engine.precompile_component(&layer.layer)?, | ||
| None => { | ||
| log::warn!("Unknow WASM binary type"); | ||
| continue; | ||
| } | ||
| }; | ||
|
|
There was a problem hiding this comment.
suggest: move this logic to Engine and add a method called fn precompile(). It is the job of the engine to handle the type of compiled_layer
There was a problem hiding this comment.
So instead of Engine::precompile like we have now, it would be Engine::precompile_module and Engine::precompile_component?
Sounds god to me.
Alternatively, a layer could have a is_component(&self) -> bool method, WDYT?
There was a problem hiding this comment.
It is the job of the engine to handle the type of compiled_layer
Not sure I understand this statement. note we have this type of logix else where in this shim https://github.com/andreiltd/runwasi/blob/e07255e7d1b6ea07ff3daa783782defd317d18b5/crates/containerd-shim-wasmtime/src/instance.rs#L258-L259
it would be Engine::precompile_module and Engine::precompile_component?
I am not excited about chaning the api or making the engine have to iterate through the layers. We delegate that to the instance so shims can handle there own layer types.
Alternatively, a layer could have a is_component(&self) -> bool method, WDYT?
Something like this makes sense if we want to move the logic our of here. Maybe a enum instead of a bool though? In spin shim it currently supports of ther layer types. We don't really wanto
Check the
wasmbinary type and choose proper precompilation method.