Improved error message for Executor::exec
#655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this commit imrpoves the error message for exec function, particularlly when the user forgot to provide Wasm file path as the arg0 for the container, it will log an error message in containerd Signed-off-by: jiaxiao zhou <[email protected]>
jsturtevant
reviewed
Jul 23, 2024
| Err(err) => { | ||
| // log an error and return | ||
| log::error!("error checking if wasm container: {err}. Note: arg0 must be a path to a Wasm file"); | ||
| InnerExecutor::CantHandle |
There was a problem hiding this comment.
it would be nice if we could pass some context to this error message so it got bubbled up to the CTR/cri error message with out having to look into the logs.
It looks like we pass the name as context, maybe we could extend it take in a message too?
There was a problem hiding this comment.
Yeah good point! I was thinking about that. I will make a PR against youki anad see if they like this idea.
jsturtevant
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit imrpoves the error message for exec function, particularlly when the user forgot to provide Wasm file path as the arg0 for the container, it will log an error message in containerd
Related #637