Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): remove the network ns in the shim start #503

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Mar 5, 2024

this commit removes the unnecessary nerwork namepsace setup in the shim start function because it is already been set in youki.

See #476

this commit removes the unnecessary nerwork namepsace setup in the
shim start function because it is already been set in youki

Signed-off-by: jiaxiao zhou <[email protected]>
@jsturtevant
Copy link
Contributor

The previous run failed, Did something change?

@Mossaka
Copy link
Member Author

Mossaka commented Mar 15, 2024

The previous run failed, Did something change?

Not really. Let me run the tests again

@Mossaka Mossaka closed this Mar 15, 2024
@Mossaka Mossaka reopened this Mar 15, 2024
@Mossaka Mossaka closed this Apr 10, 2024
@Mossaka Mossaka reopened this Apr 10, 2024
@Mossaka Mossaka closed this Apr 11, 2024
@Mossaka Mossaka reopened this Apr 11, 2024
@Mossaka
Copy link
Member Author

Mossaka commented Apr 16, 2024

1 / 5 runs the CI failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants