Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove generate_doc feature #484

Merged
merged 1 commit into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/action-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,6 @@ jobs:
run: ./scripts/setup-cross.sh ${{ inputs.target }}
- name: Build
run: make build-${{ inputs.runtime }}
- name: Validate docs
if: ${{ inputs.runtime == 'common' }}
run: ./scripts/validate-docs.sh
- name: Run tests
timeout-minutes: 5
run: |
Expand Down
1 change: 0 additions & 1 deletion crates/containerd-shim-wasm/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,3 @@ tempfile = { workspace = true }
[features]
testing = ["dep:containerd-shim-wasm-test-modules", "dep:env_logger", "dep:tempfile"]
generate_bindings = ["ttrpc-codegen"]
generate_doc = []
2 changes: 1 addition & 1 deletion crates/containerd-shim-wasm/README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
![runwasi logo](../../art/logo/runwasi_logo_icon.svg)
![runwasi logo](https://raw.githubusercontent.com/containerd/runwasi/e251de3307bbdc8bf3229020ea2ae2711f31aafa/art/logo/runwasi_logo_icon.svg)

# containerd-shim-wasm

Expand Down
11 changes: 0 additions & 11 deletions crates/containerd-shim-wasm/build.rs
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,8 @@ use std::fs;
use ttrpc_codegen::{Codegen, ProtobufCustomize};

#[cfg(not(feature = "generate_bindings"))]
#[cfg(not(feature = "generate_doc"))]
fn main() {}

#[cfg(feature = "generate_doc")]
fn main() {
use std::io::Write;
println!("cargo:rerun-if-changed=doc");
println!("cargo:rerun-if-missing=README.md");
let mut f = std::fs::File::create("README.md").unwrap();
f.write_all(include_bytes!("doc/header.md")).unwrap();
f.write_all(include_bytes!("doc/doc.md")).unwrap();
}

#[cfg(feature = "generate_bindings")]
fn main() {
println!("cargo:rerun-if-changed=protos");
Expand Down
36 changes: 0 additions & 36 deletions crates/containerd-shim-wasm/doc/doc.md

This file was deleted.

4 changes: 0 additions & 4 deletions crates/containerd-shim-wasm/doc/header.md

This file was deleted.

2 changes: 1 addition & 1 deletion crates/containerd-shim-wasm/src/lib.rs
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![doc = include_str!("../doc/doc.md")]
#![doc = include_str!("../README.md")]
#![doc(
html_logo_url = "https://raw.githubusercontent.com/containerd/runwasi/e251de3307bbdc8bf3229020ea2ae2711f31aafa/art/logo/runwasi_logo_icon.svg"
)]
Expand Down
15 changes: 0 additions & 15 deletions scripts/validate-docs.sh

This file was deleted.

Loading