-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix image name of test-image/oci #434
Conversation
Signed-off-by: Takumasa Sakao <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I think the CI is failing
Signed-off-by: Takumasa Sakao <[email protected]>
c6a394a
to
cf75085
Compare
@Mossaka Thank you for your review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!
sorry I didn't see this last week when I got back. I think this should have been an update to the README not the make files. CI was passing it was just the readme that was off |
I prefer the current change. IIUC, before both (distinct) images were using the same name, right? I think it's cleaner to give them different names, specially for local development. |
works for me |
The image name expected in
runwasi/README.md
Line 289 in ec3d24d
ghcr.io/containerd/runwasi/wasi-demo-oci
.But the image name created by
make test-image/oci
iswasi-demo-app
.So I've fixed the image name to
wasi-demo-oci
.Signed-off-by: Takumasa Sakao [email protected]