Fix image name of test-image/oci #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Takumasa Sakao <[email protected]>
Mossaka
previously approved these changes
Dec 30, 2023
Signed-off-by: Takumasa Sakao <[email protected]>
sachaos
force-pushed
the
modify-oci-image-name
branch
from
c6a394a
to
cf75085
Compare
|
@Mossaka Thank you for your review! |
jprendes
reviewed
Jan 8, 2024
|
sorry I didn't see this last week when I got back. I think this should have been an update to the README not the make files. CI was passing it was just the readme that was off |
I prefer the current change. IIUC, before both (distinct) images were using the same name, right? I think it's cleaner to give them different names, specially for local development. |
|
works for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The image name expected in
runwasi/README.md
Line 289 in ec3d24d
ghcr.io/containerd/runwasi/wasi-demo-oci.But the image name created by
make test-image/ociiswasi-demo-app.So I've fixed the image name to
wasi-demo-oci.Signed-off-by: Takumasa Sakao [email protected]