-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump versions of the containerd-shim-wasm to 0.4
and shims to 0.3
#370
Conversation
Signed-off-by: jiaxiao zhou <[email protected]>
@@ -12,7 +12,7 @@ resolver = "2" | |||
|
|||
[workspace.package] | |||
edition = "2021" | |||
version = "0.2.0" | |||
version = "0.3.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: Should we bump this to 0.4 so that it matches the lib version? Should we always keep these two the same?
I believe there's been previous discussions on this topic before, is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recall a previous discussions on this topic. I am okay with either ways.
Should we always keep these two the same?
Maybe not as crates and binaries can evolve independently imo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there was a discussion on keeping the release of each shim, as well as the lib, independent, as their versions could diverge.
(I haven't searched as I'm on mobile at the moment)
Bump containerd-shim to 0.6.0 to include structured logging. This PR will close #349 |
Signed-off-by: jiaxiao zhou <[email protected]>
it won't close it but enable it. The PR will include timestamps on our logs though 🥳 |
LGTM |
No description provided.