Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump versions of the containerd-shim-wasm to 0.4 and shims to 0.3 #370

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Oct 30, 2023

No description provided.

@Mossaka Mossaka requested review from jprendes, jsturtevant and devigned and removed request for jprendes and jsturtevant October 30, 2023 18:13
@@ -12,7 +12,7 @@ resolver = "2"

[workspace.package]
edition = "2021"
version = "0.2.0"
version = "0.3.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Should we bump this to 0.4 so that it matches the lib version? Should we always keep these two the same?

I believe there's been previous discussions on this topic before, is that correct?

Copy link
Member Author

@Mossaka Mossaka Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recall a previous discussions on this topic. I am okay with either ways.

Should we always keep these two the same?

Maybe not as crates and binaries can evolve independently imo.

Copy link
Collaborator

@jprendes jprendes Oct 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there was a discussion on keeping the release of each shim, as well as the lib, independent, as their versions could diverge.
(I haven't searched as I'm on mobile at the moment)

@Mossaka
Copy link
Member Author

Mossaka commented Oct 30, 2023

Waiting for a new release of containerd-shim crate containerd/rust-extensions#216 (comment) which adds timestamps for logs.

Bump containerd-shim to 0.6.0 to include structured logging. This PR will close #349

@jsturtevant
Copy link
Contributor

Bump containerd-shim to 0.6.0 to include structured logging. This PR will close #349

it won't close it but enable it. The PR will include timestamps on our logs though 🥳

@jsturtevant
Copy link
Contributor

LGTM

@Mossaka Mossaka merged commit 5788ced into containerd:main Oct 30, 2023
43 checks passed
@Mossaka Mossaka deleted the bump-version-0.4 branch April 8, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants