Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup unused deps and code #300

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

jprendes
Copy link
Collaborator

@jprendes jprendes commented Sep 8, 2023

This PR mainly removes code and dependencies that are no longer used.

@jprendes jprendes force-pushed the remove-unused-deps branch 8 times, most recently from 17d87f2 to 6c2ed7e Compare September 8, 2023 16:22
@jprendes jprendes closed this Sep 8, 2023
@jprendes jprendes reopened this Sep 8, 2023
@jprendes jprendes force-pushed the remove-unused-deps branch 5 times, most recently from 26b1644 to f1d6f23 Compare September 9, 2023 22:12
@Mossaka
Copy link
Member

Mossaka commented Sep 11, 2023

Need a rebase

@jprendes jprendes force-pushed the remove-unused-deps branch 2 times, most recently from 7b601f9 to 5f859e3 Compare September 11, 2023 22:18
Signed-off-by: Jorge Prendes <[email protected]>
@jprendes jprendes closed this Sep 11, 2023
@jprendes jprendes reopened this Sep 11, 2023
@jprendes jprendes marked this pull request as ready for review September 11, 2023 23:21
Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thanks

@Mossaka
Copy link
Member

Mossaka commented Sep 12, 2023

Just curious: did you use https://github.com/est31/cargo-udeps to clean up the dependencies?

@Mossaka Mossaka merged commit 7b2adf0 into containerd:main Sep 12, 2023
62 of 66 checks passed
@jprendes
Copy link
Collaborator Author

I did not! I didn't know of cargo-udeps, but I'll start using it in the future!
I did it manually this time :-)

@jprendes
Copy link
Collaborator Author

I wish clippy or fmt would also lint Cargo.toml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants