Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump rust to 1.72 #273

Merged
merged 1 commit into from
Aug 24, 2023
Merged

chore: bump rust to 1.72 #273

merged 1 commit into from
Aug 24, 2023

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Aug 24, 2023

There is an addition for resolver=2 applies to the workspace, and the reason for that is to resolve this build warning message

warning: some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest

@Mossaka
chore: bump rust to 1.72
e1fb976 
Signed-off-by: jiaxiao zhou <[email protected]>
jprendes
jprendes approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsturtevant
Copy link
Contributor

LGTM

@Mossaka Mossaka merged commit 3a5a16b into containerd:main Aug 24, 2023
12 checks passed
@Mossaka Mossaka deleted the rust-1.72 branch August 24, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprendes jprendes jprendes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mossaka @jsturtevant @jprendes