-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share artifacts between jobs #267
Conversation
Signed-off-by: Jorge Prendes <[email protected]>
7bcc641
to
f0c4675
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just had one question
They are not. WasmEdge binaries are significantly bigger than wasmtime. |
2592e67
to
f18d9d7
Compare
Signed-off-by: Jorge Prendes <[email protected]>
f18d9d7
to
8d470f8
Compare
ARG KIND_VERSION=v0.17.0 | ||
RUN curl -sSLf https://kind.sigs.k8s.io/dl/${KIND_VERSION}/kind-linux-${TARGETARCH} > /root/kind && chmod +x /root/kind | ||
ARG KIND_NODE_VERSION=v1.23.13 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be a follow up but we maybe should consider bumping this to a newer k8s version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created an issue to track this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This PR shares the artifacts created during the build jobs with the e2e test jobs.
It cuts checks times from 20~25 min to 13~16 min.
Further improvements can be made by splitting the Ubuntu based jobs and Windows base jobs, since currently Windows builds are in the critical path.