Share artifacts between jobs #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jorge Prendes <[email protected]>
jprendes
force-pushed
the
share-artifacts
branch
4 times, most recently
from
7bcc641
to
f0c4675
Compare
Mossaka
reviewed
Aug 24, 2023
|
Also noticed something interesting (not related to this PR):
Why are ubuntu 22.04 binaries significantly bigger than these in ubuntu 20.04? |
They are not. WasmEdge binaries are significantly bigger than wasmtime. |
jprendes
force-pushed
the
share-artifacts
branch
5 times, most recently
from
2592e67
to
f18d9d7
Compare
Signed-off-by: Jorge Prendes <[email protected]>
jprendes
force-pushed
the
share-artifacts
branch
from
f18d9d7
to
8d470f8
Compare
jsturtevant
reviewed
Aug 24, 2023
| ARG KIND_VERSION=v0.17.0 | ||
| RUN curl -sSLf https://kind.sigs.k8s.io/dl/${KIND_VERSION}/kind-linux-${TARGETARCH} > /root/kind && chmod +x /root/kind | ||
| ARG KIND_NODE_VERSION=v1.23.13 |
There was a problem hiding this comment.
can be a follow up but we maybe should consider bumping this to a newer k8s version
There was a problem hiding this comment.
Created an issue to track this
Mossaka
approved these changes
Aug 24, 2023
This was referenced Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR shares the artifacts created during the build jobs with the e2e test jobs.
It cuts checks times from 20~25 min to 13~16 min.
Further improvements can be made by splitting the Ubuntu based jobs and Windows base jobs, since currently Windows builds are in the critical path.