-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved determine_rootdir to containerd-shim-wasm #248
Conversation
.root | ||
.unwrap_or(container_root_dir.as_ref().to_path_buf()) | ||
.join(namespace); | ||
log::info!("youki root path is: {}", path.display()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is specific to youki, could it be moved into the libcontainer_instance folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this might not be specific to youki...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially, it uses options.json to find the root path of the container runtime (e.g. in wasmtime case, the default is /run/containerd/wasmtime
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think this is not youki's spec.
dd078b7
to
156d41f
Compare
LGTM Still seeing the out of space on ubuntu 20.04: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
65c811e
to
f06384b
Compare
f06384b
to
7cd8bd7
Compare
d09eb56
to
9e849dc
Compare
Signed-off-by: jiaxiao zhou <[email protected]>
9e849dc
to
5224c32
Compare
This PR moves determine_rootdir to containerd-shim-wasm for sharing. It also removes unused dependencies in the repo.