Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved determine_rootdir to containerd-shim-wasm #248

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Moved determine_rootdir to containerd-shim-wasm #248

merged 1 commit into from
Aug 23, 2023

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Aug 17, 2023

This PR moves determine_rootdir to containerd-shim-wasm for sharing. It also removes unused dependencies in the repo.

jsturtevant
jsturtevant reviewed Aug 17, 2023
View reviewed changes
crates/containerd-shim-wasm/src/sandbox/instance_utils.rs Outdated
.root
.unwrap_or(container_root_dir.as_ref().to_path_buf())
.join(namespace);
log::info!("youki root path is: {}", path.display());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is specific to youki, could it be moved into the libcontainer_instance folder?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this might not be specific to youki...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially, it uses options.json to find the root path of the container runtime (e.g. in wasmtime case, the default is /run/containerd/wasmtime).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think this is not youki's spec.

@jsturtevant
Copy link
Contributor

LGTM

Still seeing the out of space on ubuntu 20.04: Error: failed to create containerd container: error unpacking image: failed to extract layer sha256:a2cb83ead200443389c4237e67b65d20202ca73be5efff08d305224cd61f3313: write /var/lib/containerd/io.containerd.snapshotter.v1.overlayfs/snapshots/55/fs/bin/kindnetd: no space left on device: unknown

jprendes
jprendes approved these changes Aug 18, 2023
View reviewed changes
Copy link
Collaborator

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@Mossaka Mossaka force-pushed the refactor-rootdir branch 2 times, most recently from 65c811e to f06384b Compare August 22, 2023 21:15
@Mossaka Mossaka closed this Aug 22, 2023
@Mossaka Mossaka reopened this Aug 22, 2023
@Mossaka Mossaka merged commit 7850da8 into containerd:main Aug 23, 2023
9 checks passed
@Mossaka Mossaka deleted the refactor-rootdir branch August 23, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jprendes jprendes jprendes approved these changes

@utam0k utam0k utam0k left review comments

@jsturtevant jsturtevant Awaiting requested review from jsturtevant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mossaka @jsturtevant @jprendes @utam0k