Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds e2e to test wasmedge shim #134

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

jsturtevant
Copy link
Contributor

The wasmedge shim wasn't being tested and we have a make target that will test it.

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it looks like the gh action has "Startup failure"

@Mossaka
Copy link
Member

Mossaka commented Jun 9, 2023

Could you please fix this error?

The workflow is not valid. .github/workflows/ci.yml (Line: 87, Col: 1): Unexpected value 'e2e-wasmedge'

@jsturtevant
Copy link
Contributor Author

Could you please fix this error?

The workflow is not valid. .github/workflows/ci.yml (Line: 87, Col: 1): Unexpected value 'e2e-wasmedge'

was missing an indent 🦤

@jsturtevant
Copy link
Contributor Author

this needs a few of the updates to the makefile that are in #133. Will rebase and update once that is in

@jsturtevant jsturtevant force-pushed the add-wasmedge-job branch 2 times, most recently from adde466 to d812bc0 Compare June 9, 2023 23:43
@jsturtevant
Copy link
Contributor Author

looks like k3s didn't set up correctly in the CI:

ctr: failed to dial "/run/k3s/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/k3s/containerd/containerd.sock: connect: connection refused"

@jsturtevant
Copy link
Contributor Author

I am getting the same error locally:

$ runwasi on  add-wasmedge-job [$] is 📦 v0.1.0 via 🦀 v1.70.0 
> make test/k3s
rustup target add wasm32-wasi
info: component 'rust-std' for target 'wasm32-wasi' is up to date
cd crates/wasi-demo-app && cargo build
.....
ctr: failed to dial "/run/k3s/containerd/containerd.sock": connection error: desc = "transport: error while dialing: dial unix /run/k3s/containerd/containerd.sock: connect: connection refused"
make: *** [Makefile:96: test/k3s] Error 1

@defims any ideas?

@devigned
Copy link
Contributor

@jsturtevant my guess is that the containerd config is malformed in some way and is causing containerd to fail during startup.

@jsturtevant
Copy link
Contributor Author

Issue was that it took 20-30s for the k8s node to come fully online, it is passing now

@Mossaka
Copy link
Member

Mossaka commented Jun 12, 2023

Shall I merge?

Updates the docs to be clear about dependecies and streamlines a few files so there is concistency with make file.

Signed-off-by: James Sturtevant <[email protected]>
@jsturtevant
Copy link
Contributor Author

I rebased, added a timeout to the ctr command and removed the vscode settings file. If tests pass I think we are good 👍

@Mossaka Mossaka merged commit 44bd772 into containerd:main Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants