-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds e2e to test wasmedge shim #134
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually it looks like the gh action has "Startup failure"
Could you please fix this error?
|
b032a1d
to
aabce0b
Compare
was missing an indent 🦤 |
this needs a few of the updates to the makefile that are in #133. Will rebase and update once that is in |
adde466
to
d812bc0
Compare
looks like k3s didn't set up correctly in the CI:
|
I am getting the same error locally:
@defims any ideas? |
@jsturtevant my guess is that the containerd config is malformed in some way and is causing containerd to fail during startup. |
d812bc0
to
6dfcf11
Compare
Issue was that it took 20-30s for the k8s node to come fully online, it is passing now |
Shall I merge? |
6dfcf11
to
06e35c5
Compare
Updates the docs to be clear about dependecies and streamlines a few files so there is concistency with make file. Signed-off-by: James Sturtevant <[email protected]>
06e35c5
to
41df912
Compare
I rebased, added a timeout to the ctr command and removed the vscode settings file. If tests pass I think we are good 👍 |
The wasmedge shim wasn't being tested and we have a
make target
that will test it.