-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update youki
to include capabilities fix
#130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I think we can figure out the error handling question separately if there is a need to.
f063855
to
49a9739
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot! Added a few comments.
6fbf100
to
dc2aed5
Compare
I will rebase this PR after #132 is merged |
Merge conflict in Cargo.lock |
Rebased to fix merge conflict. |
This is important also because the oci-spec-rs 0.6.1 appears not to be compatible with the previous libcontainer SHA. |
The version of |
The youki commit where the oci-spec version is bumped is required for oci-spec 0.6.1 support for runwasi too... otherwise runwasi compilation will fail for missing Time namespace support:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
Update youki dependency to include a fix for a capabilities issue that prevented it from running inside of Docker Desktop