Fix hosts.toml resolution for docker domain #3720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: apostasie <[email protected]>
AkihiroSuda
reviewed
Dec 3, 2024
| @@ -82,6 +82,13 @@ func NewHostOptions(ctx context.Context, refHostname string, optFuncs ...Opt) (* | |||
|
|
|||
| ho.HostDir = func(hostURL string) (string, error) { | |||
| regURL, err := Parse(hostURL) | |||
| // Docker inconsistencies handling: `index.docker.io` actually expects `docker.io` for hosts.toml on the filesystem | |||
| // See https://github.com/containerd/nerdctl/issues/3697 | |||
| // FIXME: we need to reevaluate this comparing with what docker does. What should happen for FQ images with alternate docker domains? (eg: registry-1.docker.io) | |||
There was a problem hiding this comment.
Fully qualified (eg: registry-1.docker.io/library/alpine).
Acronyms are stupid. Will avoid in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3697