[release/1.7 backport] Add --pull option to build command #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sondavidb
force-pushed
the
backport-1.7-5a0558c
branch
from
63c55ac
to
23718b6
Compare
See containernetworking/plugins#1038 Signed-off-by: David Son <[email protected]>
The main branch of containerd now depends on Go 1.22, so we have to upgrade the CI to Go 1.22. The runc binary is still built with Go 1.21 due to opencontainers/runc issue 4233. Signed-off-by: Akihiro Suda <[email protected]>
Signed-off-by: David Son <[email protected]>
sondavidb
force-pushed
the
backport-1.7-5a0558c
branch
from
23718b6
to
bb9e7f0
Compare
|
I'm not sure we should backport new features to v1.7, but still negotiable if this is urgent for Finch. |
It's not urgent, and we should prepare for 2.0 upgrade anyway in the future. Closing for now, thanks for your input! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3074. Also took some helper functions for
pkg/testutil/testutil.gofrom f853ab8.Per containernetworking/plugins#1038, the binaries were modified as of the last commit so this change also brings in the new shasums so that CI runs properly.
Mainline also requires Golang 1.22 so cherry-picked 4e61592.
Feel free to close if we are not taking features into release/1.7.