Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support run container with network id #2589

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Support run container with network id #2589

merged 1 commit into from
Oct 28, 2023

Conversation

fahedouch
Copy link
Member

fix #2436

@fahedouch fahedouch force-pushed the support-run-with-network-id branch 2 times, most recently from 4218424 to 58391b8 Compare October 23, 2023 22:21
@fahedouch fahedouch added this to the v1.6.3 milestone Oct 23, 2023
@fahedouch fahedouch changed the title Support run container with network Support run container with network id Oct 23, 2023
yankay
yankay approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@yankay yankay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fahedouch

AkihiroSuda
AkihiroSuda reviewed Oct 24, 2023
View reviewed changes
cmd/nerdctl/container_run_network_linux_test.go Outdated
{
args: []string{"--net", "host"},
},
}
for _, tc := range testCases {
tc := tc // IMPORTANT
if tc.dockerIncompatible {
// docker compute id algorithm is different from nerdctl
testutil.DockerIncompatible(t)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be compatible if you inspect the id via docker network inspect

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@AkihiroSuda
Copy link
Member

Please rebase to make CI green

@fahedouch fahedouch mentioned this pull request Oct 27, 2023
Closed
AkihiroSuda
AkihiroSuda approved these changes Oct 28, 2023
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit e605881 into containerd:main Oct 28, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@yankay yankay yankay approved these changes

Assignees
No one assigned
Labels
area/network
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Cannot connect a container to a network by ID
3 participants
@fahedouch @AkihiroSuda @yankay