Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add network in use check to compose down #2051

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

Retrospection
Copy link
Contributor

Signed-off-by: YuRuosheng [email protected]

Close #1425

Resolve Comment in #1938

@Retrospection Retrospection force-pushed the master branch 2 times, most recently from 3a122ea to 995a876 Compare February 25, 2023 04:37
Copy link
Contributor

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cmd/nerdctl/compose_down_linux_test.go Outdated Show resolved Hide resolved
cmd/nerdctl/compose_down_linux_test.go Outdated Show resolved Hide resolved
pkg/cmd/compose/compose.go Outdated Show resolved Hide resolved
Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zheaoli Zheaoli merged commit 2880ddb into containerd:main Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nerdctl compose down with orphan container should keep the same behavior with docker
4 participants