-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the rename command on Windows #1993
Fix the rename command on Windows #1993
Conversation
base.Cmd("ps", "-a").AssertOutContains(testContainerName + "_new") | ||
base.Cmd("rename", testContainerName, testContainerName+"_new").AssertFail() | ||
base.Cmd("rename", testContainerName+"_new", testContainerName+"_new").AssertFail() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this test pass on Linux too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the test.
5eb3dd2
to
3d5b02b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Ping. |
CI is failing
|
3d5b02b
to
b81ee79
Compare
Oh interesting, is the test added here the first hyperv test we have? |
Signed-off-by: Dan Ardelean <[email protected]>
b81ee79
to
abb1da2
Compare
Fixed, added a check to see if HyperV is enabled, if not skip the test. |
The rename command did not work on Windows due to the
hostst.Update()
function that works only for Linux. The etchosts mechanism on Windows does nothing atm.Signed-off-by: Dan Ardelean [email protected]