Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support argument --mac-address for nerdctl run command #1407

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Support argument --mac-address for nerdctl run command #1407

merged 1 commit into from
Oct 6, 2022

Conversation

yuchanns
Copy link
Contributor

@yuchanns yuchanns commented Oct 3, 2022 •
edited
Loading

Fix #1382

  • Support for both nerdctl run and nerdctl create commands.
  • Support for --network=bridge.
  • Partial support for --network=<network> (when actual network types are one of bridge and macvlan).
  • Code implementation
  • Add integration tests
  • Add document

Signed-off-by: Hanchin Hsieh [email protected]

@junnplus junnplus self-requested a review October 4, 2022 01:05
@yuchanns yuchanns marked this pull request as ready for review October 4, 2022 12:00
@yuchanns
Copy link
Contributor Author

yuchanns commented Oct 4, 2022

PTAL @AkihiroSuda @junnplus

junnplus
junnplus reviewed Oct 4, 2022
View reviewed changes
cmd/nerdctl/run_network.go Outdated Show resolved Hide resolved
junnplus
junnplus reviewed Oct 4, 2022
View reviewed changes
cmd/nerdctl/run_network.go Outdated Show resolved Hide resolved
junnplus
junnplus reviewed Oct 4, 2022
View reviewed changes
cmd/nerdctl/run_network.go Outdated Show resolved Hide resolved
junnplus
junnplus reviewed Oct 4, 2022
View reviewed changes
cmd/nerdctl/run_network.go Outdated Show resolved Hide resolved
junnplus
junnplus reviewed Oct 4, 2022
View reviewed changes
cmd/nerdctl/run_network.go Outdated Show resolved Hide resolved
Zheaoli
Zheaoli requested changes Oct 4, 2022
View reviewed changes
cmd/nerdctl/create_linux_test.go Show resolved Hide resolved
cmd/nerdctl/create_linux_test.go Outdated Show resolved Hide resolved
manugupt1
manugupt1 reviewed Oct 4, 2022
View reviewed changes
cmd/nerdctl/run_network_linux_test.go Outdated Show resolved Hide resolved
cmd/nerdctl/run_network_linux_test.go Show resolved Hide resolved
cmd/nerdctl/run.go Show resolved Hide resolved
cmd/nerdctl/run_network.go Show resolved Hide resolved
junnplus
junnplus approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@junnplus junnplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

Zheaoli
Zheaoli approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@Zheaoli Zheaoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @AkihiroSuda

AkihiroSuda
AkihiroSuda approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda added this to the v0.23.1 milestone Oct 6, 2022
@AkihiroSuda AkihiroSuda merged commit 37c681b into containerd:master Oct 6, 2022
@yuchanns yuchanns deleted the issue-1382 branch October 6, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manugupt1 manugupt1 manugupt1 left review comments

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@junnplus junnplus junnplus approved these changes

@Zheaoli Zheaoli Zheaoli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

how to set mac address
5 participants
@yuchanns @manugupt1 @Zheaoli @junnplus @AkihiroSuda