Skip to content

Commit

Permalink
Split rootless driver tests by network driver and portdriver.
Browse files Browse the repository at this point in the history
Each combination of networkdriver and port driver takes
around 20 mins and since they were serialized it took around 40 mins.
By Splitting into different jobs, the test runs can run faster.

Signed-off-by: Manu Gupta <[email protected]>
  • Loading branch information
manugupt1 committed Feb 10, 2023
1 parent 109f7fb commit 587e627
Showing 1 changed file with 20 additions and 7 deletions.
27 changes: 20 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,29 +113,42 @@ jobs:
include:
- ubuntu: 20.04
containerd: v1.5.17
target: test-integration-rootless
- ubuntu: 20.04
containerd: v1.6.16
target: test-integration-rootless
- ubuntu: 22.04
containerd: v1.6.16
target: test-integration-rootless
- ubuntu: 22.04
containerd: main
target: test-integration-rootless
- ubuntu: 20.04
containerd: v1.5.17
target: test-integration-rootless-port-slirp4netns
- ubuntu: 20.04
containerd: v1.6.16
target: test-integration-rootless-port-slirp4netns
- ubuntu: 22.04
containerd: v1.6.16
target: test-integration-rootless-port-slirp4netns
- ubuntu: 22.04
containerd: main
target: test-integration-rootless-port-slirp4netns
env:
UBUNTU_VERSION: "${{ matrix.ubuntu }}"
CONTAINERD_VERSION: "${{ matrix.containerd }}"
TEST_TARGET: "${{ matrix.target }}"
steps:
- uses: actions/[email protected]
with:
fetch-depth: 1
- name: "Register QEMU (tonistiigi/binfmt)"
run: docker run --privileged --rm tonistiigi/binfmt --install all
- name: "Prepare (network driver=slirp4netns, port driver=builtin)"
run: DOCKER_BUILDKIT=1 docker build -t test-integration-rootless --target test-integration-rootless --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} .
- name: "Test (network driver=slirp4netns, port driver=builtin)"
run: docker run -t --rm --privileged test-integration-rootless
- name: "Prepare (network driver=slirp4netns, port driver=slirp4netns)"
run: DOCKER_BUILDKIT=1 docker build -t test-integration-rootless-port-slirp4netns --target test-integration-rootless-port-slirp4netns --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} .
- name: "Test (network driver=slirp4netns, port driver=slirp4netns)"
run: docker run -t --rm --privileged test-integration-rootless-port-slirp4netns
run: DOCKER_BUILDKIT=1 docker build -t ${TEST_TARGET} --target ${TEST_TARGET} --build-arg UBUNTU_VERSION=${UBUNTU_VERSION} --build-arg CONTAINERD_VERSION=${CONTAINERD_VERSION} .
- name: "Test (network driver=slirp4netns, port driver=builtin)"
run: docker run -t --rm --privileged ${TEST_TARGET}

cross:
runs-on: ubuntu-22.04
Expand Down

0 comments on commit 587e627

Please sign in to comment.