Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

Add unix:// prefix for socket addresses used by CRI remote client. #748

Merged
merged 1 commit into from
Apr 23, 2018

Conversation

Random-Liu
Copy link
Member

Kubelet and crictl prefers socket address with unix:// prefix, or else it prints out warning. https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/util/util_unix.go#L75

For example:

# crictl ps
W0420 17:20:40.130286  237131 util_unix.go:75] Using "/run/containerd/containerd.sock" as endpoint is deprecated, please consider using full url format "unix:///run/containerd/containerd.sock".
CONTAINER ID        IMAGE               CREATED             STATE               NAME                ATTEMPT

This PR adds unix:// prefix to all containerd socket addresses except the ones passed to containerd client, because containerd client doesn't work with the unix:// prefix.

Signed-off-by: Lantao Liu [email protected]

@Random-Liu Random-Liu added this to the v1.0.0 milestone Apr 21, 2018
@Random-Liu
Copy link
Member Author

This PR also updates cri-tools to include the fix kubernetes-sigs/cri-tools#291

@Random-Liu
Copy link
Member Author

/test pull-cri-containerd-build

Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@Random-Liu Random-Liu merged commit 09ff081 into containerd:master Apr 23, 2018
@Random-Liu Random-Liu deleted the use-full-sock-path branch April 23, 2018 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants