-
Notifications
You must be signed in to change notification settings - Fork 348
vendor: update kubernetes to v1.18.0-beta.1 #1413
Conversation
That didn't work out well; that's a lot of "red". 😞 |
Ah; new dependency. Thought I checked them all
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
okay, that repo just tagged v3.0.0, so I'm gonna slightly diverge from the version that kubernetes uses, which is 5 commits behind; kubernetes-sigs/structured-merge-diff@5e70324...v3.0.0 |
b60e7d0
to
3ec28fc
Compare
Not out of the woods yet. Was afraid that would happen. Probably should update containerd first;
|
a2bc18b
to
914d498
Compare
Signed-off-by: Sebastiaan van Stijn <[email protected]>
no local changes Signed-off-by: Sebastiaan van Stijn <[email protected]>
full diff: kubernetes-sigs/yaml@v1.1.0...v1.2.0 Signed-off-by: Sebastiaan van Stijn <[email protected]>
Signed-off-by: Sebastiaan van Stijn <[email protected]>
914d498
to
a3e7f68
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thx for also doing the integration test change, don't you love it when public scoped utility apis completely change without so much as a comment..
Yes, always fun. It's why I make so many jokes about Go projects all of a sudden using "SemVer" because of go modules |
temporarily rebased on top of #1414 to run CI before that one is mergeddone