-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
contrib/fuzz: fix broken OSS-Fuzz build #7288
Conversation
Signed-off-by: AdamKorcz <[email protected]>
Hi @AdamKorcz. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -49,8 +49,7 @@ mv temp-go/go/* /root/.go/ | |||
cd $SRC/containerd | |||
|
|||
go mod tidy | |||
rm vendor/github.com/cilium/ebpf/internal/btf/fuzz.go | |||
rm /root/go/pkg/mod/github.com/cilium/[email protected]/internal/btf/fuzz.go | |||
go get github.com/cilium/ebpf@latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this get a specific version so it doesn't break later?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
We should upgrade containerd/cgroups instead of patching that in this shell script. |
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288. Signed-off-by: Kazuyoshi Kato <[email protected]>
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288. Signed-off-by: Kazuyoshi Kato <[email protected]>
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288. Signed-off-by: Kazuyoshi Kato <[email protected]>
Closing per fix in #7304 |
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288. Signed-off-by: Kazuyoshi Kato <[email protected]>
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288. Signed-off-by: Kazuyoshi Kato <[email protected]>
The fuzzer is broken and it breaks OSS-Fuzz according to containerd#7288. Signed-off-by: Kazuyoshi Kato <[email protected]>
A broken fuzzer in an old version of github.com/cilium/ebpf breaks the OSS-Fuzz build. This PR fixes that by using the latest version of the dependency which does not have the broken fuzzer.
Signed-off-by: AdamKorcz [email protected]