Skip to content

Commit

Permalink
CI: Pass GITHUB_TOKEN to containerd/project-checks
Browse files Browse the repository at this point in the history
Previously the project-checks action was failing sometimes due to
hitting GitHub API rate limits. Since no token was supplied, the rate
limits were only 60 requests/hour keyed off the IP address of the
runner.

Now, passing GITHUB_TOKEN secret through to project-checks, we have a
limit of 1000 requests/hour for the whole repo. This should alleviate
the rate limits that were being seen.

I believe it is safe to pass this secret as project-checks is also owned
by the containerd organization. The secret is also scoped to the actions
run, and is invalidated upon completion.

project-checks version is also updated to the version that supports
repo-access-token input.

Signed-off-by: Kevin Parsons <[email protected]>
(cherry picked from commit 79d09c6)
Signed-off-by: Derek McGowan <[email protected]>
  • Loading branch information
kevpar authored and dmcgowan committed Jan 4, 2023
1 parent f28bb76 commit b573670
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,10 @@ jobs:
path: src/github.com/containerd/containerd
fetch-depth: 100

- uses: containerd/project-checks@v1
- uses: containerd/project-checks@v1.1.0
with:
working-directory: src/github.com/containerd/containerd
repo-access-token: ${{ secrets.GITHUB_TOKEN }}

- name: verify go modules and vendor directory
run: |
Expand Down

0 comments on commit b573670

Please sign in to comment.