Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat.] Support 'prioritize files' as a new prefetch mode #296

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

BigVan
Copy link
Member

@BigVan BigVan commented Aug 6, 2024

What this PR does / why we need it:

The current trace-record mode is difficult to use in non-production environments. This PR adds a new prefetch mode called 'prioritize files', people can set a filelist to download target files in advance.

See details in 'docs/trace-prefetch.md'

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/trace-prefetch.md Outdated Show resolved Hide resolved
docs/trace-prefetch.md Outdated Show resolved Hide resolved
@yuchen0cc yuchen0cc added the ok-to-test Pull request is ok to run ci test label Aug 7, 2024
@BigVan BigVan force-pushed the prefetch_conf branch 4 times, most recently from 1207401 to 0187cee Compare August 8, 2024 03:37
See details in 'docs/trace-prefetch.md'

Signed-off-by: Yifan Yuan <[email protected]>
Copy link
Contributor

@yuchen0cc yuchen0cc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuchen0cc yuchen0cc merged commit e4e6077 into containerd:main Aug 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants