Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convertor: support reference API #294

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

WaberZhuang
Copy link
Contributor

@WaberZhuang WaberZhuang commented Jul 26, 2024

What this PR does / why we need it:
Add option --referrer so that the converted image will be referenced to the original image through Referrers API. The artifact type for overlaybd and turboOCIv1 is application/vnd.containerd.overlaybd.native.v1+json and application/vnd.containerd.overlaybd.turbo.v1+json respectively.

Please see the changes in USERSPACE_CONVERTOR document for more details.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@liulanzheng
Copy link
Member

change alibaba.overlaybd to containerd.overlaybd?

Signed-off-by: zhuangbowei.zbw <[email protected]>
@yuchen0cc yuchen0cc added the ok-to-test Pull request is ok to run ci test label Jul 29, 2024
@WaberZhuang
Copy link
Contributor Author

change alibaba.overlaybd to containerd.overlaybd?

Already updated as suggested, and since this repository is a containerd subproject, it does make more sense to use containerd.overlaybd.

Copy link
Member

@liulanzheng liulanzheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liulanzheng liulanzheng merged commit e4abacf into containerd:main Jul 30, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants