Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable TurboOCI format for EROFS #291

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Enable TurboOCI format for EROFS #291

merged 2 commits into from
Jul 3, 2024

Conversation

hsiangkao
Copy link
Contributor

@hsiangkao hsiangkao commented Jun 27, 2024

What this PR does / why we need it:
Enable TurboOCI format for EROFS filesystem

To build a EROFS TurboOCI image,
$ bin/convertor --fstype erofs -r <repo> -i <input-tag> --turboOCI <turboOCI-tag>

If --fstype is not given, ext4 is used by default.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

We need to find the specific files in the unpacked tar layer for
TurboOCI multiple fs support, so move it to sn.Commit().

Signed-off-by: Gao Xiang <[email protected]>
@BigVan
Copy link
Member

BigVan commented Jun 28, 2024

LGTM
please take a review @WaberZhuang

Copy link
Contributor

@WaberZhuang WaberZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BigVan BigVan added the ok-to-test Pull request is ok to run ci test label Jul 3, 2024
Similiar to EXT4 which uses "ext4.fs.meta", add EROFS metadata
"erofs.fs.meta" support too.  Multiple metadata could exist in
each TurboOCI layer, but let's make single fs metadata work first.

To build a EROFS TurboOCI image,
$ bin/convertor --fstype erofs -r <repo> -i <input-tag> --turboOCI <turboOCI-tag>

If `--fstype` is not given, ext4 is used by default.

Signed-off-by: Gao Xiang <[email protected]>
@BigVan BigVan merged commit e01b2e1 into containerd:main Jul 3, 2024
9 checks passed
@hsiangkao hsiangkao deleted the erofs_turbooci branch July 3, 2024 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Pull request is ok to run ci test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants