-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies (containerd v2) #290
Conversation
@liulanzheng not quite sure why the CI would use go 1.19 (as I did upgrade to 1.22)? Thanks. |
Rebased against latest main. e2e still failing as they rely on go 1.19 apparently. |
@yuchen0cc It seems that the CI was using the script from the main branch instead of the script modified in the PR. How should this situation be handled? |
@apostasie After confirming with @yuchen0cc, to prevent potential attacks from CI, the CI runs the code from the target branch. Therefore, we have to merge the code first before running the new CI. Additionally, could we merge the zdfs first before merging this branch? |
Thanks @liulanzheng ! For sure - we do need the zdfs PR merged first. If you want, I can ping you back here once it is done and this one is updated to reflect that. |
Signed-off-by: apostasie <[email protected]>
Hey @liulanzheng zdfs PR got merged last night. I just updated this here so that we are back on zdfs main instead of my fork (thanks to @AkihiroSuda help). I guess this here is ready for review (or merge on a feature branch?) Let me know if you need anything else here from me. Thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only involves dependency changes. It is recommended to merge first and then check the e2e results.
All CI passed |
Thanks a lot @liulanzheng ! Appreciate the help. |
What this PR does / why we need it:
Hi folks.
This PR updates dependencies, with a specific focus on containerd (v2).
It also bumps the go version to align with ^, upgrades github actions and urfave (v2).
Please NOTE that currently this is swapping out
github.com/data-accelerator/zdfs
togithub.com/apostasie/zdfs
and should of course NOT be merged as-is. Evidently, as soon as the PR on zdfs gets through I will update this to make it ready (data-accelerator/zdfs#3).Please check the following list:
Let me know your thoughts.
Thanks a lot.