Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: can't support writable label in Cri #123

Closed
BigVan opened this issue Jun 22, 2022 · 0 comments
Closed

BUG: can't support writable label in Cri #123

BigVan opened this issue Jun 22, 2022 · 0 comments

Comments

@BigVan
Copy link
Member

BigVan commented Jun 22, 2022

Sandbox container can't start with annotation 'containerd.io/snapshot/overlaybd.writable: dir'.

Here is the deploy yaml:

### cat ./pod-config.yaml
metadata:
  attempt: 1
  uid: 1
  name: redis-obd
  namespace: default-1
log_directory: /tmp
linux:
  security_context:
    namespace_options:
      network: 2
annotations:
  containerd.io/snapshot/overlaybd.writable: dir

### cat ./container-config.yaml 
metadata:
  name: redis-obd-container
image:
  image: registry.hub.docker.com/overlaybd/redis:6.2.1_obd
log_path: redis.container.log

It will return error when using the command 'crictl run container-config.yaml pod-config.yaml'

E0620 22:24:50.095847   12072 remote_runtime.go:212] "RunPodSandbox from runtime service failed" err="rpc error: code = Unknown desc = failed to create containerd container: failed to read config(path=/var/lib/overlaybd/snapshots/12/block/config.v1.json) of snapshot 12: open /var/lib/overlaybd/snapshots/12/block/config.v1.json: no such file or directory: unknown"
DEBU[0000] RunPodSandboxResponse:                       
FATA[0000] running container: run pod sandbox: rpc error: code = Unknown desc = failed to create containerd container: failed to read config(path=/var/lib/overlaybd/snapshots/12/block/config.v1.json) of snapshot 12: open /var/lib/overlaybd/snapshots/12/block/config.v1.json: no such file or directory: unknown 
BigVan added a commit to BigVan/accelerated-container-image that referenced this issue Jun 22, 2022
overlaybd snapshotter should check the image type when the label
'containerd.io/snapshot/overlaybd.writable' has been set.

this value should be ignore for normal image.

Signed-off-by: Yifan Yuan <[email protected]>
@BigVan BigVan closed this as completed in af92c29 Jun 22, 2022
HileQAQ pushed a commit to HileQAQ/accelerated-container-image that referenced this issue Oct 14, 2022
overlaybd snapshotter should check the image type when the label
'containerd.io/snapshot/overlaybd.writable' has been set.

this value should be ignored for normal images. containerd#123

Signed-off-by: Yifan Yuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant