[OCP3] Support header-only signed RPMs #1650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLOUDBLD-7002 There are 4 RPM tags that can contain signatures [1]. Two of them are calculated from the header+payload - SIGPGP and SIGGPG. The other two are calculated only from the header - DSAHEADER and RSAHEADER. Header signatures were added in rpm v4 and the header+payload ones have slowly been getting phased out since then [2]. The default rpm behavior is now to include only the header signature [3]. What this means for OSBS is simply that we need to start looking at the header signatures as well, where previously we would only consider the header+payload ones. [1]: https://rpm-software-management.github.io/rpm/manual/tags.html [2]: rpm-software-management/rpm#863 [3]: rpm-software-management/rpm@b1aeafe Signed-off-by: Adam Cmiel <[email protected]>
|
backporting #1649 |
rcerven
approved these changes
Aug 27, 2021
ben-alkov
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOUDBLD-7002
There are 4 RPM tags that can contain signatures 1. Two of them are
calculated from the header+payload - SIGPGP and SIGGPG. The other two
are calculated only from the header - DSAHEADER and RSAHEADER.
Header signatures were added in rpm v4 and the header+payload ones have
slowly been getting phased out since then 2. The default rpm behavior
is now to include only the header signature 3.
What this means for OSBS is simply that we need to start looking at the
header signatures as well, where previously we would only consider the
header+payload ones.
Signed-off-by: Adam Cmiel [email protected]
Maintainers will complete the following section