Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update action to use node20 #20

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

gansheer
Copy link
Contributor

@gansheer
Copy link
Contributor Author

gansheer commented Mar 12, 2024

@squakez could you tell me if there is a ci failure not linked to #19 ? 🙏

@squakez
Copy link
Contributor

squakez commented Mar 12, 2024

Most probably it's linked with that issue.

@gansheer
Copy link
Contributor Author

Most probably it's linked with that issue.

Can it be merged then ?

@squakez squakez merged commit 0ad70e2 into container-tools:main Mar 14, 2024
9 of 17 checks passed
@karfau
Copy link

karfau commented Apr 24, 2024

It looks like the release is tagged in the repository and that version is also listed in the GitHub Marketplace, but when using the action v2 it is still resulting in a warning about using node16.

Maybe it is related to the failed checks on the main branch?

Found the issue: the v2 tag is still pointing to f47f727, so using the full version should be a workaround.

@squakez
Copy link
Contributor

squakez commented Apr 24, 2024

Found the issue: the v2 tag is still pointing to f47f727, so using the full version should be a workaround.

You need to use v2.0.4 which is the version that had this fixed. We haven't updated v2 which is the same as v2.0.0.

@karfau
Copy link

karfau commented Apr 24, 2024

May it's worth mentioning this in the readme, since it is very common to do that, and it is recommended in the github docs: https://docs.github.com/en/actions/creating-actions/releasing-and-maintaining-actions#example-developer-process

We recommend creating releases using semantically versioned tags – for example, v1.1.3 – and keeping major (v1) and minor (v1.1) tags current to the latest appropriate commit. For more information, see "About custom actions" and "About semantic versioning.

@squakez
Copy link
Contributor

squakez commented Apr 25, 2024

I'll do an update shortly then.

@squakez
Copy link
Contributor

squakez commented Apr 25, 2024

Should be done now. v2 is updated to v2.0.4 git commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants