Clean up proto naming #176
Conversation
|
/assign @saad-ali |
csi.proto
Outdated
| @@ -413,7 +413,7 @@ message ListVolumesRequest { | |||
|
|
|||
| message ListVolumesResponse { | |||
| message Entry { | |||
| VolumeInfo volume_info = 1; | |||
| Volume volume_info = 1; | |||
|
Minor change requested, otherwise, LGTM |
|
@saad-ali thanks for catching that, fixed. |
|
@jieyu please review when you have a chance |
| @@ -717,7 +717,7 @@ message ControllerPublishVolumeResponse { | |||
| // The SP specific information that will be passed to the Plugin in | |||
| // the subsequent `NodePublishVolume` call for the given volume. | |||
| // This information is opaque to the CO. This field is OPTIONAL. | |||
| map<string, string> publish_volume_info = 1; | |||
| map<string, string> publish_volume = 1; | |||
There was a problem hiding this comment.
I would actually rename this to publish_info. publish_volume sounds a bit weird.
There was a problem hiding this comment.
Yep, +1 for publish_info, done
There was a problem hiding this comment.
All of our fields that used to be uintXX were typed that way because negative values aren't allowed. Now that they're converted to their sibling intXX type, I'm wondering if we need additional language regarding the treatment of negative values? It certainly adds validation code for plugins and COs implementing the spec because now they need to deal with possibly invalid, negative numbers.
|
Closing as the branch stoped accepting any changes. This PR addresses the same issues: #182 |
Closes: #172 #173 #174
These are breaking changes from the 0.1 release.