Address review comments

container-storage-interface · Apr 13, 2020 · f3133c6 · f3133c6
1 parent 843742f
commit f3133c6
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 10 deletions.
diff --git a/csi.proto b/csi.proto
@@ -991,7 +991,8 @@ message ControllerServiceCapability {
       // ListVolumesResponse.entry.published_nodes field
       LIST_VOLUMES_PUBLISHED_NODES = 10;
 
-      // Indicates the SP supports controller level volume condition.
+      // Indicates that the Controller service can report volume
+      // conditions.
       // An SP MAY implement `VolumeCondition` in only the Controller
       // Plugin, only the Node Plugin, or both.
       // If `VolumeCondition` is implemented in both the Controller and
@@ -1364,7 +1365,7 @@ message VolumeUsage {
   Unit unit = 4;
 }
 
-// VolumeCondition represents the current condition of a volume
+// VolumeCondition represents the current condition of a volume.
 message VolumeCondition {
   option (alpha_message) = true;
 
@@ -1399,7 +1400,7 @@ message NodeServiceCapability {
       GET_VOLUME_STATS = 2;
       // See VolumeExpansion for details.
       EXPAND_VOLUME = 3;
-      // Indicates the SP supports node level volume condition.
+      // Indicates that the Node service can report volume conditions.
       // An SP MAY implement `VolumeCondition` in only the Node
       // Plugin, only the Controller Plugin, or both.
       // If `VolumeCondition` is implemented in both the Node and

diff --git a/lib/go/csi/csi.pb.go b/lib/go/csi/csi.pb.go
diff --git a/spec.md b/spec.md
@@ -1548,7 +1548,9 @@ message ControllerGetVolumeResponse {
 
 ##### ControllerGetVolume Errors
 
-If the plugin is unable to complete the ControllerGetVolume call successfully, it MUST return a non-ok gRPC code in the gRPC status. If the conditions defined below are encountered, the plugin MUST return the specified gRPC error code. The CO MUST implement the specified error recovery behavior when it encounters the gRPC error code.
+If the plugin is unable to complete the ControllerGetVolume call successfully, it MUST return a non-ok gRPC code in the gRPC status.
+If the conditions defined below are encountered, the plugin MUST return the specified gRPC error code.
+The CO MUST implement the specified error recovery behavior when it encounters the gRPC error code.
 
 | Condition | gRPC Code | Description | Recovery Behavior |
 |-----------|-----------|-------------|-------------------|
@@ -1646,7 +1648,8 @@ message ControllerServiceCapability {
       // ListVolumesResponse.entry.published_nodes field
       LIST_VOLUMES_PUBLISHED_NODES = 10;
 
-      // Indicates the SP supports controller level volume condition.
+      // Indicates that the Controller service can report volume
+      // conditions.
       // An SP MAY implement `VolumeCondition` in only the Controller
       // Plugin, only the Node Plugin, or both.
       // If `VolumeCondition` is implemented in both the Controller and
@@ -2365,7 +2368,7 @@ message VolumeUsage {
   Unit unit = 4;
 }
 
-// VolumeCondition represents the current condition of a volume
+// VolumeCondition represents the current condition of a volume.
 message VolumeCondition {
   option (alpha_message) = true;
 
@@ -2419,7 +2422,7 @@ message NodeServiceCapability {
       GET_VOLUME_STATS = 2;
       // See VolumeExpansion for details.
       EXPAND_VOLUME = 3;
-      // Indicates the SP supports node level volume condition.
+      // Indicates that the Node service can report volume conditions.
       // An SP MAY implement `VolumeCondition` in only the Node
       // Plugin, only the Controller Plugin, or both.
       // If `VolumeCondition` is implemented in both the Node and