Skip to content

Commit

Permalink
spec: AlphaFeature capability for all services.
Browse files Browse the repository at this point in the history
A new AlphaFeature message type was added for each of the plugin,
controller, and node services. Experimental features supported by the SP
should be advertised via one or more of the following RPCs:

* Identity.GetPluginCapabilities
* Controller.ControllerGetCapabilities
* Node.NodeGetCapabilities
  • Loading branch information
James DeFelice authored and xing-yang committed Feb 24, 2020
1 parent b38e833 commit cb44c3c
Show file tree
Hide file tree
Showing 3 changed files with 534 additions and 220 deletions.
36 changes: 36 additions & 0 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -226,10 +226,22 @@ message PluginCapability {
Type type = 1;
}

message AlphaFeature {
enum Type {
UNKNOWN = 0;
}

Type type = 1; // REQUIRED
}

oneof type {
// Service that the plugin supports.
Service service = 1;
VolumeExpansion volume_expansion = 2;

// AlphaFeature indicates that an experimental feature is offered by
// the plugin.
AlphaFeature alpha_feature = 3;
}
}
message ProbeRequest {
Expand Down Expand Up @@ -950,9 +962,21 @@ message ControllerServiceCapability {
Type type = 1;
}

message AlphaFeature {
enum Type {
UNKNOWN = 0;
}

Type type = 1; // REQUIRED
}

oneof type {
// RPC that the controller supports.
RPC rpc = 1;

// AlphaFeature indicates that an experimental feature is offered by
// the controller service.
AlphaFeature alpha_feature = 2;
}
}
message CreateSnapshotRequest {
Expand Down Expand Up @@ -1323,9 +1347,21 @@ message NodeServiceCapability {
Type type = 1;
}

message AlphaFeature {
enum Type {
UNKNOWN = 0;
}

Type type = 1; // REQUIRED
}

oneof type {
// RPC that the controller supports.
RPC rpc = 1;

// AlphaFeature indicates that an experimental feature is offered by
// the node service.
AlphaFeature alpha_feature = 2;
}
}
message NodeGetInfoRequest {
Expand Down
Loading

0 comments on commit cb44c3c

Please sign in to comment.