Skip to content

Commit

Permalink
Mark feature as experimental
Browse files Browse the repository at this point in the history
  • Loading branch information
xing-yang committed Feb 13, 2020
1 parent ebec916 commit 5c862b2
Show file tree
Hide file tree
Showing 3 changed files with 321 additions and 234 deletions.
33 changes: 29 additions & 4 deletions csi.proto
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,23 @@ extend google.protobuf.FieldOptions {
// Indicates that a field MAY contain information that is sensitive
// and MUST be treated as such (e.g. not logged).
bool csi_secret = 1059;

// Indicates that this field is OPTIONAL and part of an experimental
// API that may be deprecated and eventually removed between minor
// releases.
bool alpha_field = 1060;
}
extend google.protobuf.MessageOptions {
// Indicates that this message is OPTIONAL and part of an experimental
// API that may be deprecated and eventually removed between minor
// releases.
bool alpha_message = 1060;
}
extend google.protobuf.MethodOptions {
// Indicates that this method is OPTIONAL and part of an experimental
// API that may be deprecated and eventually removed between minor
// releases.
bool alpha_method = 1060;
}
service Identity {
rpc GetPluginInfo(GetPluginInfoRequest)
Expand Down Expand Up @@ -62,7 +79,9 @@ service Controller {
returns (ControllerExpandVolumeResponse) {}

rpc GetVolume (GetVolumeRequest)
returns (GetVolumeResponse) {}
returns (GetVolumeResponse) {
option (alpha_method) = true;
}
}

service Node {
Expand Down Expand Up @@ -820,7 +839,7 @@ message ListVolumesResponse {
// This field MUST be specified if the
// LIST_VOLUMES_VOLUME_HEALTH controller capability is supported.
// This field is OPTIONAL.
repeated VolumeHealth volume_health = 2;
repeated VolumeHealth volume_health = 2 [(alpha_field) = true];
}

message Entry {
Expand All @@ -844,17 +863,21 @@ message ListVolumesResponse {
string next_token = 2;
}
message GetVolumeRequest {
option (alpha_message) = true;

// Identity information for a specific volume. This field is
// REQUIRED. GetVolume will return with current volume information.
string volume_id = 1;
}

message GetVolumeResponse {
option (alpha_message) = true;

message VolumeStatus{
// volume_health shows error conditions reported by the SP.
// This field MUST be specified if the
// VOLUME_HEALTH controller capability is supported.
repeated VolumeHealth volume_health = 1;
repeated VolumeHealth volume_health = 1 [(alpha_field) = true];
}

// This field is REQUIRED
Expand Down Expand Up @@ -1276,7 +1299,7 @@ message NodeGetVolumeStatsResponse {
// This field is OPTIONAL.
repeated VolumeUsage usage = 1;
// This field is OPTIONAL.
repeated VolumeHealth volume_health = 2;
repeated VolumeHealth volume_health = 2 [(alpha_field) = true];
}

message VolumeUsage {
Expand All @@ -1302,6 +1325,8 @@ message VolumeUsage {
}

message VolumeHealth {
option (alpha_message) = true;

enum Condition {
// Volume health condition is unknown; treat it as healthy.
UNKNOWN = 0;
Expand Down
Loading

0 comments on commit 5c862b2

Please sign in to comment.