-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Export adapter #45
base: artifact-list-export-adapter
Are you sure you want to change the base?
Fix Export adapter #45
Conversation
adds adapter
Adds the registry URL to the state artifact file instead of its name
Signed-off-by: bupd <[email protected]>
Quality Gate passedIssues Measures |
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
stage.go should not change, it has an impact on other adapters, preventing them from working.
log.Debugf("assembling dest resources...") | ||
|
||
// Check condition to determine whether to assemble list or destination resources | ||
if policy.DestRegistry.Type == "artifact-list-export" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see some debug print statements left in the code. But the most important thing is that such PR won't be accepted by the community of Harbor. We can't place such a switcher inside of core logic.
There is some issue at the replication at |
Update the artifact-list-export to harbor-satellite. |
Signed-off-by: bupd <[email protected]>
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
Thank you for contributing to Harbor!
Comprehensive Summary of your change
state artifact
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: