Merge pull request #15 from apasel422/untuck

remove blanket impl for comparator references

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 
 name = "compare"
-version = "0.0.4"
+version = "0.0.5"
 license = "MIT/Apache-2.0"
 description = "Experimental comparators for collections to be generic over"
 

src/lib.rs

@@ -132,7 +132,7 @@ use std::default::Default;
 use std::marker::PhantomData;
 use std::fmt::{self, Debug};
 
-/// Returns the maximum of two values according to the given comparator, or `lhs` if they
+/// Returns the maximum of two values according to the given comparator, or `rhs` if they
 /// are equal.
 ///
 /// # Examples
@@ -147,15 +147,15 @@ use std::fmt::{self, Debug};
 /// let f3 = &Foo { key: 'b', id: 3};
 ///
 /// let cmp = Extract::new(|f: &Foo| f.key, natural());
-/// assert_eq!(max(&cmp, f1, f2).id, f1.id);
+/// assert_eq!(max(&cmp, f1, f2).id, f2.id);
 /// assert_eq!(max(&cmp, f1, f3).id, f3.id);
 /// ```
 // FIXME: convert to default method on `Compare` once where clauses permit equality
 // (https://github.com/rust-lang/rust/issues/20041)
 pub fn max<'a, C: ?Sized, T: ?Sized>(cmp: &C, lhs: &'a T, rhs: &'a T) -> &'a T
     where C: Compare<T> {
 
-    if cmp.compares_ge(lhs, rhs) { lhs } else { rhs }
+    if cmp.compares_ge(rhs, lhs) { rhs } else { lhs }
 }
 
 /// Returns the minimum of two values according to the given comparator, or `lhs` if they
@@ -322,14 +322,6 @@ impl<F: ?Sized, Lhs: ?Sized, Rhs: ?Sized> Compare<Lhs, Rhs> for F
     fn compare(&self, lhs: &Lhs, rhs: &Rhs) -> Ordering { (*self)(lhs, rhs) }
 }
 
-impl<'a, Lhs: ?Sized, Rhs: ?Sized, C: ?Sized> Compare<Lhs, Rhs> for &'a C
-    where C: Compare<Lhs, Rhs> {
-
-    fn compare(&self, lhs: &Lhs, rhs: &Rhs) -> Ordering {
-        Compare::compare(*self, lhs, rhs)
-    }
-}
-
 /// A comparator that borrows its parameters before comparing them.
 ///
 /// See [`Compare::borrow`](trait.Compare.html#method.borrow) for an example.